Keeps improving the sceGu definitions and implementation
#282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
339ae4c to
550ce73
Compare
- Fix sceGuBreak - Fix sceGuContinue - Fix sceGuDrawArrayN - Fix sceGuMorphWeight - Remove unnecessary 0xffffff as it is done by sendCommandi - Improve the name of some parameters - Create and use GU_MAX_STATUS - Remove magic numbers in `sceGuMaterial` - Remove magic numbers in `sceGuMorphWeight` - Remove magic numbers in `sceGuSetMatrix` - Remove magic numbers in `sceGuSignal`
diamant3
approved these changes
May 5, 2025
Member
|
I tested OceanPop with this change and it does not seem to have any impact. The code does look much cleaner, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR just keeps doing some clean-ups and tiny improvements around the
sceGucode.sceGuBreaksceGuContinuesceGuDrawArrayNsceGuMorphWeightsceGuMaterialsceGuSetMatrixsceGuSignal0xffffffas it is done bysendCommandiGU_MAX_STATUSCheers