Improve sceGuSignal usage
#306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bucanero
approved these changes
Jun 20, 2025
bucanero
reviewed
Jun 20, 2025
| if (gu_call_mode == GU_CALL_SIGNAL) | ||
| { | ||
| sendCommandi(SIGNAL, (list_addr >> 16) | 0x110000); | ||
| sendCommandi(SIGNAL, (0x11 << 16) | (list_addr >> 16)); |
Contributor
There was a problem hiding this comment.
I like the old syntax (list_addr >> 16) | 0x110000 as it's clearer to me, but it's probably just my personal preference.
Member
Author
There was a problem hiding this comment.
Same here… 0x11 is an specific command
bucanero
reviewed
Jun 20, 2025
| if (gu_call_mode == GU_CALL_SIGNAL) | ||
| { | ||
| sendCommandi(SIGNAL, 0x120000); | ||
| sendCommandi(SIGNAL, 0x12 << 16); |
Contributor
There was a problem hiding this comment.
same here, I'd keep 0x120000 (personal preference)
Member
Author
There was a problem hiding this comment.
The reason why I split it is because 0x12 is actually part of a GE command when SIGNAL CMD is used.
sharkwouter
reviewed
Jun 20, 2025
sharkwouter
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the function definition of
sceGuSignalandsceGuCallMode, having now better-named parameters and a better description too.Additionally, I have fixed the usage in the examples that PSPSDK has.