Improve performance of BaseCursor.description(). #1240
Closed
+301
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is opened after noticing
descriptionis much slower in 3.x. I'm pretty unfamiliar with psycopg (and even more so with cython) so this might be more of a starting point for discussion.Changes
reset().Columnclass so libpq can be called directly.Benchmarking
Benchmark code (table has ~20 columns):
Rough timing from my machine:
psycopg2(2.9.11) - 0.004170051 seconds (4170051 ns)psycopg[c](3.3.2) - 2.072374879 seconds (2072374879 ns)psycopg[c](with this PR) - 0.395435509 seconds (395435509 ns)Testing
There are no API changes so the existing tests should be sufficient.