Feature: add callback to area_printer and interactive_select_printer#579
Draft
copydataai wants to merge 4 commits intopterm:masterfrom
Draft
Feature: add callback to area_printer and interactive_select_printer#579copydataai wants to merge 4 commits intopterm:masterfrom
copydataai wants to merge 4 commits intopterm:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #579 +/- ##
==========================================
+ Coverage 82.00% 82.04% +0.04%
==========================================
Files 32 32
Lines 3623 3632 +9
==========================================
+ Hits 2971 2980 +9
Misses 605 605
Partials 47 47
☔ View full report in Codecov by Sentry. |
|
Sorry for random commenting. I like a feature like this so that I can build something like fzf preview. Seems like owner prefer to use "copy" when "WithXXX()". Every "With" call with have a new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a callback function as a field to area_printer to be executed every time on area.Update
Scope
Related Issue
Fixes #
To-Do Checklist