feat: interactive confirm with confirmation#648
Open
KarolosLykos wants to merge 6 commits intopterm:masterfrom
Open
feat: interactive confirm with confirmation#648KarolosLykos wants to merge 6 commits intopterm:masterfrom
KarolosLykos wants to merge 6 commits intopterm:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #648 +/- ##
==========================================
+ Coverage 80.71% 80.86% +0.14%
==========================================
Files 33 33
Lines 4210 4248 +38
==========================================
+ Hits 3398 3435 +37
- Misses 738 739 +1
Partials 74 74 ☔ View full report in Codecov by Sentry. |
|
It feels a bit odd that after typing |
|
apart of that, I like it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #644
To address this, I propose introducing a new option
WithConfirmation(true)to thepterm.DefaultInteractiveConfirmto enable the behavior of waiting for the user to confirm their answer by pressing the<Enter>key.I have created a draft pull request that introduces this new option named WithConfirmation. I'm seeking feedback on whether you agree with this approach and if you'd like to proceed with it.