Add CI lint check for DOS (CRLF) line endings#3607
Open
runlevel5 wants to merge 2 commits intoptitSeb:mainfrom
Open
Add CI lint check for DOS (CRLF) line endings#3607runlevel5 wants to merge 2 commits intoptitSeb:mainfrom
runlevel5 wants to merge 2 commits intoptitSeb:mainfrom
Conversation
Convert README.md, docs/CHANGELOG.md, and docs/COMPILE.md from DOS (CRLF) to Unix (LF) line endings to be consistent with the rest of the codebase. Ref: ptitSeb#3605
Add a new GitHub Actions workflow that fails if any file (excluding known legacy CRLF files) has DOS line endings. This prevents new CRLF files from being introduced into the codebase. Ref: ptitSeb#3605
Owner
|
I'm sorry but I fail to see why it's important? Current tooling should be able to handle both LF/CRLF in a transparent way. Do you have tools that doesn't? |
Contributor
Author
I reckon to have a rails guard is better than nothing. Since we've already had 31 files that have DOS (CRLF) line endings and whilst many are not might lead to confusion to newcomers, they might create new files with DOS (CRLF). Btw I think it's pretty standardized to have linter or git precommit hook for auto-formatter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README.md,docs/CHANGELOG.md, anddocs/COMPILE.mdfrom DOS (CRLF) to Unix (LF) line endingsLintGitHub Actions workflow (.github/workflows/lint.yml) that detects CRLF line endings in any tracked file and fails the build if found — preventing new CRLF files from being introducedRef: #3605