Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Prevent to visit node that got dropped later in loop #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

kylekatarnls
Copy link
Member

@kylekatarnls kylekatarnls commented Dec 30, 2022

Credit to @userqq, see #36 (comment)

Fix #36

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (102c921) compared to base (f9db663).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #38   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       502       506    +4     
===========================================
  Files             34        34           
  Lines           1246      1251    +5     
===========================================
+ Hits            1246      1251    +5     
Impacted Files Coverage Δ
src/JsPhpize/Compiler/Compiler.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kylekatarnls kylekatarnls force-pushed the fix/issue-36-add-performance branch from 6349e85 to 102c921 Compare December 30, 2022 08:29
@codeclimate
Copy link

codeclimate bot commented Dec 30, 2022

Code Climate has analyzed commit 102c921 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@kylekatarnls kylekatarnls merged commit cbf05dc into master Dec 30, 2022
@kylekatarnls kylekatarnls deleted the fix/issue-36-add-performance branch August 29, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwanted visitNode call
1 participant