Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: Add CONTRIBUTING.md - #14

Merged
simenandre merged 4 commits into
mainfrom
add-contributing
Sep 13, 2022
Merged

chore: Add CONTRIBUTING.md#14
simenandre merged 4 commits into
mainfrom
add-contributing

Conversation

@simenandre

Copy link
Copy Markdown
Member

fixes #10

Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md
@simenandre
simenandre requested a review from ringods May 18, 2022 07:34
tenwit
tenwit previously approved these changes Jul 26, 2022
Comment thread CONTRIBUTING.md
@ringods
ringods requested review from rawkode and usrbinkat and removed request for aaronkao, mattstratton and stack72 July 27, 2022 07:50
@ringods

ringods commented Jul 27, 2022

Copy link
Copy Markdown
Member

I updated the list of reviewers to match the Governance Board. @rawkode and @usrbinkat, could you provide your feedback on this contributing.md document?

At the moment, I'm still not convinced on the convenctional commit aspect but that is mainly because I have never used it myself. @cobraz could you set up a repo where this is applied, have that bot you were referring to active on the repo and demo the whole setup to us? I can only agree on something if I better understand how it works and where it actually solves something or helps us.

@simenandre

simenandre commented Jul 27, 2022

Copy link
Copy Markdown
Member Author

At the moment, I'm still not convinced on the convenctional commit aspect but that is mainly because I have never used it myself. @cobraz could you set up a repo where this is applied, have that bot you were referring to active on the repo and demo the whole setup to us? I can only agree on something if I better understand how it works and where it actually solves something or helps us.

What exactly aren't you convinced about? Is this is mainly about lowering the bar on community contributions?

IMHO, when compared to having to manually add a CHANGELOG, this is less work for a contributor. It's also something they never need to worry about, since this whole thing can be implemented by making sure pull request titles adhere to conventional commits (and squashing). Which is easy for a maintainer to ensure, all without a contributor even thinking about it.

This isn't about a bot. It's about how we communicate commits, so that we can automate. I don't see how setting up a repository to demo anything helps. You can check many of the examples out in the wild. Give me a second to gather some

@tenwit tenwit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up issue raised, #24

@simenandre
simenandre merged commit 290a2fc into main Sep 13, 2022
@simenandre
simenandre deleted the add-contributing branch September 13, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add contributing

4 participants