Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jarretlavallee
Copy link
Contributor

This assumes #43 is merged first.

Update PDK and the changelog for a 1.1.0 release.

Jarret Lavallee added 4 commits August 7, 2020 13:23
Prior to this commit, there were additional 4.x tests added to for
travis. The minimum puppet version in the metadata.json is 5.5.0, so
these tests are not needed. This commit removes the testing from the
.sync.yml
Prior to this commit, there were facts required for spec tests that were
manually added to the default_facts.yaml. These would be overwritten on
a pdk update as they were not in the .sync.yml. This commit adds those
facts to the .sync.yml so they persist pdk updates.
This commit updates PDK to 1.18.1.
@jarretlavallee jarretlavallee requested a review from m0dular August 7, 2020 19:34
Copy link
Member

@Sharpie Sharpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Bump the version number in metadata.json --- unless that will be done as a separate change.

This commit updates the version from 1.0.1 to 1.1.0.
@jarretlavallee jarretlavallee merged commit c1b6102 into master Aug 7, 2020
@jarretlavallee jarretlavallee deleted the maint/master/update_pdk branch August 7, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants