Thanks to visit codestin.com
Credit goes to github.com

Skip to content

(Bug) - Remove default switch of UpdateEnabled=false when Action=Install #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2023
Merged

(Bug) - Remove default switch of UpdateEnabled=false when Action=Install #466

merged 1 commit into from
Dec 21, 2023

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented Dec 20, 2023 •
edited
Loading

Summary

Prior to this PR, since v3.3.0 of this module, the Install switch /UpdateEnabled always defaulted to FALSE when the instance /ACTION=Install. This took away the ability for users to be able to configure this install switch themselves, and is an obvious bug.

Additional Context

Introduced in #420

Related Issues (if any)

Fixes #462

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@jordanbreen28 jordanbreen28 changed the title (Bug) - Remove default switch of updateenabled false (Bug) - Remove default switch of UpdateEnabled=false when Action=Install Dec 20, 2023
@jordanbreen28 jordanbreen28 force-pushed the maint-fix_install_flags branch 6 times, most recently from 232af9d to 19a73f7 Compare December 21, 2023 10:02
(Bug) - Remove default switch of updateenabled false
19d435b 
Prior to this commit, since v3.3.0 of this module,
the Install switch /UpdateEnabled always defaulted
to FALSE when the instance /ACTION=Install.

This took away the ability for users to be able to
configure this install switch themselves,
and is an obvious bug.

Now, this no longer automatically prepends the flag to
install switches when action=install, and allows users
to configure this through install_switches property
once again.
@jordanbreen28 jordanbreen28 force-pushed the maint-fix_install_flags branch from 19a73f7 to 19d435b Compare December 21, 2023 10:58
@jordanbreen28 jordanbreen28 marked this pull request as ready for review December 21, 2023 12:12
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner December 21, 2023 12:12
@Ramesh7 Ramesh7 merged commit d5796e0 into main Dec 21, 2023
@Ramesh7 Ramesh7 deleted the maint-fix_install_flags branch December 21, 2023 12:31
@jordanbreen28 jordanbreen28 mentioned this pull request Dec 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ramesh7 Ramesh7 Ramesh7 approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to Apply SQL Server Updates when /ACTION = INSTALL
2 participants
@jordanbreen28 @Ramesh7