Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add createImageDataWith #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2021
Merged

Add createImageDataWith #81

merged 2 commits into from
Sep 5, 2021

Conversation

ozkutuk
Copy link
Contributor

@ozkutuk ozkutuk commented Sep 4, 2021 •
edited
Loading

Description of the change

Fixes #80

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@ozkutuk
Copy link
Contributor Author

ozkutuk commented Sep 5, 2021

I have also noticed this library lacks an eslint config. I have copied the "standard" config and fixed the issues. Should I add these changes to this PR as well, or should I create a new PR?

@thomashoneyman
Copy link
Contributor

Could you create a new PR, please? Thanks!

@thomashoneyman thomashoneyman merged commit 60791cc into purescript-web:master Sep 5, 2021
@ozkutuk ozkutuk mentioned this pull request Sep 5, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing binding to the ImageData constructor
2 participants
@ozkutuk @thomashoneyman