Fix broken window export, causing the function to return itself #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to have been introduced with the lebab updates. In the working group package set it was using this version: https://github.com/kl0tl/purescript-web-html/blob/es-modules/src/Web/HTML.js |
src/Web/HTML.js
Outdated
Comment on lines
1
to
3
| @@ -1,3 +1,3 @@ | |||
| export function window() { | |||
| export function windowImpl() { | |||
| return window; | |||
| } | |||
There was a problem hiding this comment.
Can't this fix just be
const windowImpl = function() {
return window;
}
export windowImpl as window;similar to what we've done for new?
|
Good catch! |
JordanMartinez
approved these changes
Apr 14, 2022
thomashoneyman
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
purescript-webprojects. Although MDN is a great resource, it is not a suitable reference for this project.Description of the change
Bugfix: Export of window is wrong, causing the function to return itself.
Checklist: