Thanks to visit codestin.com
Credit goes to github.com

Skip to content

increase the size of the local payload check #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Conversation

benw-pusher
Copy link
Contributor

What does this PR do?

Increases the size limit of the event payload in the local checks. This prevents two issues:

  • sys.getsizeof calculates the size of the payload in memory, which can be larger that the size of the payload in the network HTTP request. This means some payloads are incorrectly blocked by this check.
  • some dedicated clusters have a higher max payload size. This library in its current format does not support such clusters.

This change is safe as the API already checks the size of events and returns an error if too large.

  • If you have changed dependencies, ensure both requirements.txt and setup.py have been updated

CHANGELOG

  • [CHANGED] the maximum event payload size permitted by this library has been increased. This change affects the library only: the Channels API still maintains a 10kb size limit and will return an error if the payload is too large.

@fbenevides fbenevides merged commit 30da4c0 into master Jan 24, 2023
@fbenevides fbenevides deleted the increase-size-check branch January 24, 2023 16:11
@fbenevides fbenevides mentioned this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants