Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Acanguven
Copy link
Member

What's this PR do?

Adds conditional page routes

{
      name: 'about',
      url: '/about',
      condition: (req) => {
        return req.cookies.pageenabled === 'yes'
      },
      html: 'page content'
}

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #87 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #87      +/-   ##
=========================================
+ Coverage   86.28%   86.3%   +0.01%     
=========================================
  Files          36      36              
  Lines        1714    1716       +2     
  Branches      338     339       +1     
=========================================
+ Hits         1479    1481       +2     
  Misses        235     235
Impacted Files Coverage Δ
src/configurator.ts 95.52% <ø> (ø) ⬆️
src/storefront.ts 95.4% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1102b01...38658c0. Read the comment docs.

@erdoganoksuz erdoganoksuz merged commit c60e621 into master May 23, 2019
@erdoganoksuz erdoganoksuz deleted the feature/conditional-page-route branch May 23, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants