pyupgrade --py36-plus, license year #1050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, I believe we can overlook the remaining coverage issues in |
mikofski
reviewed
Sep 6, 2020
mikofski
reviewed
Sep 6, 2020
mikofski
reviewed
Sep 6, 2020
mikofski
reviewed
Sep 6, 2020
mikofski
reviewed
Sep 6, 2020
mikofski
reviewed
Sep 6, 2020
mikofski
reviewed
Sep 6, 2020
mikofski
reviewed
Sep 6, 2020
mikofski
reviewed
Sep 6, 2020
mikofski
reviewed
Sep 6, 2020
There was a problem hiding this comment.
Looks great, thanks! I found a few more strings that could be converted to f-strings. Not sure why pyupgrade didn't catch them, but I tested them and they seem to work
Also wasn't sure where test_get_sky_diffuse_invalid came from, seems not related to this pr.
Co-authored-by: Mark Mikofski <[email protected]>
Co-authored-by: Mark Mikofski <[email protected]>
Co-authored-by: Mark Mikofski <[email protected]>
Co-authored-by: Mark Mikofski <[email protected]>
Co-authored-by: Mark Mikofski <[email protected]>
Co-authored-by: Mark Mikofski <[email protected]>
Co-authored-by: Mark Mikofski <[email protected]>
Co-authored-by: Mark Mikofski <[email protected]>
Co-authored-by: Mark Mikofski <[email protected]>
|
thanks @mikofski I noticed a couple of those and forgot to go through more carefully.
A |
mikofski
approved these changes
Sep 6, 2020
|
okay to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).These changes are the result of the following command:
The diff looks good to me except for maybe a couple of minor style issues. Let's see what the full test suite says...