Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove unnecessary **kwargs from spa_python and get_total_irradiance #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 6, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added v0.9.2.rst, changes in pvlib/irradiance.py and pvlib/location.py
Made new v0.9.2.rst and removed **kwargs from pvlib/irradiance.py (Line 309) and pvlib/location.py (Line 234-235)
  • Loading branch information
Naman-Priyadarshi committed Apr 5, 2022
commit 310c0a521d36ccb97c1f9dbb4547e01b51c5544c
26 changes: 26 additions & 0 deletions docs/sphinx/source/whatsnew/v0.9.2.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
.. _whatsnew_0920:

v0.9.2 (April 5, 2022)
-----------------------

Deprecations
~~~~~~~~~~~~

Enhancements
~~~~~~~~~~~~

Bug fixes
~~~~~~~~~

Testing
~~~~~~~

Documentation
~~~~~~~~~~~~~

Requirements
~~~~~~~~~~~~

Contributors
~~~~~~~~~~~~
* Naman Priyadarshi (:ghuser:`Naman-Priyadarshi`)
2 changes: 1 addition & 1 deletion pvlib/irradiance.py
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ def get_total_irradiance(surface_tilt, surface_azimuth,
dni, ghi, dhi, dni_extra=None, airmass=None,
albedo=.25, surface_type=None,
model='isotropic',
model_perez='allsitescomposite1990', **kwargs):
model_perez='allsitescomposite1990'):
r"""
Determine total in-plane irradiance and its beam, sky diffuse and ground
reflected components, using the specified sky diffuse irradiance model.
Expand Down
3 changes: 1 addition & 2 deletions pvlib/location.py
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,7 @@ def get_clearsky(self, times, model='ineichen', solar_position=None,
pressure = atmosphere.alt2pres(self.altitude)

if solar_position is None:
solar_position = self.get_solarposition(times, pressure=pressure,
**kwargs)
solar_position = self.get_solarposition(times, pressure=pressure)

apparent_zenith = solar_position['apparent_zenith']
apparent_elevation = solar_position['apparent_elevation']
Expand Down