Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Change freq M to MS #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2025
Merged

Conversation

AdamRJensen
Copy link
Member

@AdamRJensen AdamRJensen commented Jun 5, 2025

  • I am familiar with the contributing guidelines
  • Tests added
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The freq='1M' is used in a couple of places in the pvlib iotools functions, which results in the following future warning:

FutureWarning: 'M' is deprecated and will be removed in a future version, please use 'ME' instead.
months = pd.date_range(

The frequency 'M' is being phased out in favor of 'ME' and 'MS' which correspond to month end and month start. 'M' is equivalent to 'ME'. However, 'MS' is the only one supported in our minimum Pandas version, whereas 'ME' was first introduced in a later version. For the iotools functions, I think 'MS' is conceptually more correct.

Minimum changes to the lookup linked turbidity functions were made to make tests pass. I preferred making these modifications over calculating new test values.

Mostly a duplicate of #2266. The difference is that this PR does not remove the label parameter in the get_cams function, as this should be done in a separate PR.

@AdamRJensen
Copy link
Member Author

@kandersolar I don't think a whatsnew entry is warranted for these behind-the-scenes changes. Please thumbs up/down this comment.

@AdamRJensen AdamRJensen marked this pull request as ready for review June 5, 2025 18:03
@kandersolar kandersolar added this to the v0.12.1 milestone Jun 5, 2025
@kandersolar kandersolar added the remote-data triggers --remote-data pytests label Jun 5, 2025
@AdamRJensen AdamRJensen added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels Jun 6, 2025
@kandersolar kandersolar merged commit 62535f8 into pvlib:main Jun 6, 2025
36 checks passed
@AdamRJensen AdamRJensen mentioned this pull request Jun 6, 2025
6 tasks
@AdamRJensen AdamRJensen deleted the change-freq-M-to-MS branch June 6, 2025 21:08
@kandersolar kandersolar modified the milestones: v0.12.1, v0.13.0 Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement io remote-data triggers --remote-data pytests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants