pvsystem clean up #51
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important parts of this PR are
pvsystem.sapm
to follow the rules discussed in consistent variable names and capitalization #37 and the wiki. Would be good for people to look at this and make sure that they're happy with how it looks in practice.pvsystem.sapm
documentation is more complete. Some module parameters were misnamed and we were missing some others.Less important changes:
Ee
to thepvsystem.sapm
output DataFrame. Not sure if this name follows the rules or not. It's a parameter that's very specific to the Sandia model, so that makes me think that it's better to leave asEe
.pvsystem.sapm
can now take a dict for a module specification.