Hey,
Sorry I missed your first message.
Would definitely be nice to get that change across. I was not able to run the tests, but it works for my usage.

@bartdag if I were to pick this up and make the requested changes do you think we could get it merged and released?

@ihleonard-c3 Thanks for bringing this up. Missed the original notification :)

@bartdag I've addressed your comments.

I'm more than happy to run the tests but every time I tried they just seem to hang. Looks like @antoine-guillou had the same issue. Any thoughts on that?
Or maybe there's a more up-to-date readme somewhere?

I still need to find a better CI environment, but last time I committed code the tests ran fine on Travis-CI and locally on mac and linux. You should be able to at least run the test method you wrote even if the whole test suite does not complete locally.

@ihleonard-c3 Thanks for bringing this up. Missed the original notification :)

Thank you for picking it back up!

@chernias yes, I can confirm that my original modifications made some tests in client_server_test.py hang (testJavaGC, testMultiClientServer...) If I revert my changes the tests pass.

If I run the hanging tests in debug, and run the faulty line in the debug console, it does not hang but provides me the error message.

AttributeError: 'NoneType' object has no attribute 'gateway_client

error occuring in clientserver.py where I wrote (~line 584):

if (not isinstance(return_value, JavaObject)) and ( not self.python_server.gateway_client.converters is None):

Testing if self.python_server not None on the same if statement makes the tests in client_server_test.py pass:

if (not isinstance(return_value, JavaObject)) and (self.python_server is not None) and (self.python_server.gateway_client.converters is not None)

Probably easier for you to incorporate this line into your branch than me forking your fork to create a pull request 🙃

@antoine-guillou Thanks! I've added it.
Tests definitely progressed further, but they still get stuck after a few minutes. I'll try to see what's going on when I have time.

Hey @bartdag.
I've ran nosetests py4j.tests.java_list_test since they include auto convert checks and they seem to be passing.
As mentioned above the whole set still hangs after some time so I'll try to take a look into that.

...
----------------------------------------------------------------------
Ran 12 tests in 30.840s

OK

Just following up again to see if I can help here. Thanks

Bump again

Hey @bartdag. Do you have any other concerns regarding this or are we good to finally merge? :)