Thanks to visit codestin.com
Credit goes to github.com

Skip to content

#379 Timeout for starting Java process in launch_gateway #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#379 Timeout for starting Java process in launch_gateway #544

wants to merge 2 commits into from

Conversation

avpavlov
Copy link

Make CallbackClient to use daemon thread so it does not prevent GatewayServer from exit

I observed the same issue as in #379

Quick investigation shown that Java Process did not exit and the only non-daemon thread was pool thread

"pool-1-thread-1" #13 prio=5 os_prio=31 cpu=3.68ms elapsed=72.09s tid=0x00007fd38b144800 nid=0x7403 waiting on condition  [0x000070000574e000]
   java.lang.Thread.State: TIMED_WAITING (parking)
	at jdk.internal.misc.Unsafe.park([email protected]/Native Method)
	- parking to wait for  <0x000000070f22e028> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
	at java.util.concurrent.locks.LockSupport.parkNanos([email protected]/LockSupport.java:234)
	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos([email protected]/AbstractQueuedSynchronizer.java:2123)
	at java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take([email protected]/ScheduledThreadPoolExecutor.java:1182)
	at java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take([email protected]/ScheduledThreadPoolExecutor.java:899)
	at java.util.concurrent.ThreadPoolExecutor.getTask([email protected]/ThreadPoolExecutor.java:1054)
	at java.util.concurrent.ThreadPoolExecutor.runWorker([email protected]/ThreadPoolExecutor.java:1114)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run([email protected]/ThreadPoolExecutor.java:628)
	at java.lang.Thread.run([email protected]/Thread.java:829)

This PR makes pool to create daemon thread so this will not prevent failed JVM from exiting

py4j#379 Timeout for starting Java process in launch_gateway
50102fb 
Make CallbackClient to use daemon thread so it does not prevent GatewayServer from exit
@avpavlov
Copy link
Author

@HyukjinKwon please take a look

@gerashegalov gerashegalov mentioned this pull request Feb 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@avpavlov