Add token and pin initialization#110
Open
maxwolfe wants to merge 1 commit into
Open
Conversation
69ae329 to
a261695
Compare
Author
|
I wrote this casually for personal use and am not super familiar with extending Python with C, so please don't hesitate to comment if there are better ways to do certain things. |
a261695 to
69d938a
Compare
Added as Token.init_token and Session.init_pin
69d938a to
287dd87
Compare
danni
reviewed
Jan 17, 2022
danni
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed. Apologies for the delay. Not sure why I never got notified for this.
| assertRV(_funclist.C_InitToken(slot_id, pin_data, pin_length, | ||
| label)) | ||
|
|
||
| return True |
Collaborator
There was a problem hiding this comment.
Rather than returning True/False out of this function, it's probably better to return None or raise ArgumentsBad. That means you can try/except/finally your codepath.
| tlabel = token_label.encode('utf-8') | ||
|
|
||
| if pin and tlabel: | ||
| pin_data = pin |
Collaborator
There was a problem hiding this comment.
I don't think you need to reassign these?
Collaborator
There was a problem hiding this comment.
Oh, I suppose you do for nogil, NM
| pin = user_pin.encode('utf-8') | ||
|
|
||
| if pin: | ||
| pin_data = pin |
Collaborator
There was a problem hiding this comment.
I don't think you need to reassign this.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding implementations and tests for C_InitToken and C_InitPIN
Happens to also solve: #6