Port most of the code to Python3 compatible. - #122
Merged
Merged
Conversation
|
Great job! I will test this soon hopefully. |
Collaborator
|
Looks good, thanks! |
schaul
added a commit
that referenced
this pull request
Mar 24, 2014
Port most of the code to Python3 compatible.
|
@schaul , sorry for commenting in a issue that is already closed. Should I try to port the entire code to Python3 or should I leave Python2 compatible? |
Collaborator
|
The ideal version would have the same code work with both Python 2 and 3, and it should be possible to do that, but in case of conflict, maintaining compatibility with Python 2 is the priority (at least for the near future). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code should still work on Python2.
Import and print are the main changes.
Not everything might be ported. The most part that was left intact are the
range(). In Python2 it returns a list and in python it returns an iterator. This should speed up and in most cases should work without further changes.See http://www.diveinto.org/python3/porting-code-to-python-3-with-2to3.html#xrange