Update sequential.py - #207
Open
gissemari wants to merge 1 commit into
Open
Conversation
This modfiication in splitWithProportion would allow to call it before or after a _convertToOneOfMany for datasets of type ClassificationDataSet: Case after converting: it would raise the error "IndexError: Classes and 1-of-k representation out of sync!" due to passing the data arrays in the datasetClass() instead of just the dimensions (that sets outdimension in more than one) but having incosistant the 'class' tag of the new arrays (leftDs and rightDs). Case before converting: it is not guarantee that testDataSet and trainDataSet contain the same number of classes that the original dataset had. So, when trying to convert to many classes each dataset, there would be an out-of-index error newtarg's target would have the dimension according on how many different classes the testDataSet or traingDataSet had.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modfiication in splitWithProportion would allow us to call it before or after a _convertToOneOfMany, obtain the correct type if it is ClassificationDataSet and maintain the speed benefit of not adding sample by sample: