Thanks to visit codestin.com
Credit goes to github.com

Skip to content

x509 Verification: Ensure SAN is always checked for servers.#12454

Merged
alex merged 4 commits into
pyca:mainfrom
deivse:x509_verif_serververifier_always_checks_san
Feb 14, 2025
Merged

x509 Verification: Ensure SAN is always checked for servers.#12454
alex merged 4 commits into
pyca:mainfrom
deivse:x509_verif_serververifier_always_checks_san

Conversation

@deivse

@deivse deivse commented Feb 14, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@deivse

deivse commented Feb 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Initial version of what we discussed in #11800, without the check in PolicyDefinition::new. I'll look into that in a bit.

@deivse deivse mentioned this pull request Feb 14, 2025
Merged
@deivse

deivse commented Feb 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I decided to do the second part in it's own PR to keep PRs small.
PS: once again it's not me, actions are acting up 😄

@deivse deivse marked this pull request as ready for review February 14, 2025 11:06
@deivse deivse mentioned this pull request Feb 14, 2025
Merged
alex
alex reviewed Feb 14, 2025
View reviewed changes
Comment thread src/rust/cryptography-x509-verification/src/policy/extension.rs Outdated
alex
alex reviewed Feb 14, 2025
View reviewed changes
Comment thread src/rust/cryptography-x509-verification/src/policy/extension.rs
@alex alex enabled auto-merge (squash) February 14, 2025 13:38
@alex alex merged commit 1664aea into pyca:main Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex alex alex approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deivse @alex