This repository was archived by the owner on Sep 10, 2024. It is now read-only.
Fix/loramesh example #103
Merged
Fix/loramesh example #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rc_cb needs two parameters, the callback routine and the sockets which should be checked for incoming data (https://docs.pycom.io/firmwareapi/pycom/network/lora/pymesh.html#meshrxcbhandler-argument) without fixing this, the example will crash after connecting to the mesh network see forum entry: https://forum.pycom.io/topic/4912/loramesh-example-crashing-on-lopy4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
rc_cb needs two parameters, the callback routine and the sockets which should be checked for incoming data
(https://docs.pycom.io/firmwareapi/pycom/network/lora/pymesh.html#meshrxcbhandler-argument
without fixing this, the example will crash after connecting to the mesh network
see forum entry: https://forum.pycom.io/topic/4912/loramesh-example-crashing-on-lopy4
Does this close any currently open issues?
Any relevant logs, error output, etc?
Any other comments?
Where has this been tested?
lopy4 v1.20.0.rc11
os.uname()output:(sysname='LoPy4', nodename='LoPy4', release='1.20.0.rc11', version='v1.9.4-0a38f88 on 2019-05-14', machine='LoPy4 with ESP32', lorawan='1.0.2', sigfox='1.0.1')