FIX: guard second usage of PyWeakref_GetObject#934
Merged
swt2c merged 4 commits intopycurl:masterfrom Feb 7, 2026
Merged
Conversation
This function was deprecated in 3.13 and will be removed in 3.15. There are two usages in pycurl, one in easy.c was already correctly guarded, the other in share.c was not.
c297b5b to
21bb17d
Compare
Contributor
Author
|
The failure looks like it might be related, but if it was caused by this I would have expected it on all of the py313 and py314 runs not just one macos py314. |
Contributor
|
It does look related. @aeroyorch can you please take a look? |
aeroyorch
suggested changes
Jan 29, 2026
Contributor
Author
|
I think it is closer to right now (correctly handles the dead ref case), but I think something is still not right with the error-path in the 3.13 code path. |
obj is only `None` in the <3.13 code path if the weakref is dead. Handle and return early to simplify later code.
aeroyorch
approved these changes
Jan 30, 2026
Contributor
|
Looks good to me. Can it be moved from draft to ready? |
Contributor
|
@tacaswell is this ready? |
tacaswell
commented
Feb 4, 2026
Contributor
Author
|
@aeroyorch Ok, I think this is good to go. If the weakref call fails, |
aeroyorch
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function was deprecated in 3.13 and will be removed in 3.15. There are two usages in pycurl, one in easy.c was already correctly guarded, the other in share.c was not.
I am not sure what should be done in the case where PyWeakref_GetRef reports an error in this function.