CodSpeed Performance Report

Merging #10815 will improve performances by ×3.3

_{Comparing fix-uv (d6b33cd) with main (c7a3d5c)}

Summary

⚡ 3 improvements
✅ 41 untouched benchmarks

Benchmarks breakdown

Deploying pydantic-docs with    Cloudflare Pages

View logs

Re eedf556:

I don't think tzdata should be added to dev, as we don't have email-validator there. They're both extras...
So, we should probably add conditional skips to those tests accordingly, like you've done for the email validator ones.

Also, we should investigate the perf bottlenecks here - very odd...

Coverage report

This PR does not seem to contain any modification to coverable code.

Perf regressions are because pytest-memray is now being installed; for whatever reason our benchmarks are measuring pytest hook execution time...

Looks like @pytest.mark.benchmark is the problematic pattern, measuring the wrong thing.

@sydney-runkle I think this is ready.

@samuelcolvin,

LGTM, though I don't think you addressed this one: #10815 (comment)

Re eedf556:

I don't think tzdata should be added to dev, as we don't have email-validator there. They're both extras... So, we should probably add conditional skips to those tests accordingly, like you've done for the email validator ones.

It has to be included for windows tests, hence the hint.

Alright! Let's merge then.

Thanks for the improvements here 👍, looking much cleaner.