Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding citation file #9088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 25, 2024
Merged

Adding citation file #9088

merged 6 commits into from
Mar 25, 2024

Conversation

priya-gitTest
Copy link
Contributor

@priya-gitTest priya-gitTest commented Mar 23, 2024 •
edited
Loading

Change Summary

Related issue number

Fix #6700

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @hramezani

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 23, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9088 will degrade performances by 18.13%

Comparing priya-gitTest:PydanticCitation (0dac5bd) with main (f794f65)

Summary

⚡ 5 improvements
❌ 3 regressions
✅ 2 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main priya-gitTest:PydanticCitation Change
⚡ test_fastapi_startup_perf 3.6 s 1.6 s ×2.2
⚡ test_fastapi_startup_perf 1,272.6 ms 192.8 ms ×6.6
⚡ test_north_star_json_dumps 180.3 ms 124.6 ms +44.67%
❌ test_north_star_json_loads 97.4 ms 117 ms -16.75%
⚡ test_north_star_validate_json 296.6 ms 258.2 ms +14.88%
⚡ test_north_star_validate_json_strict 300.8 ms 257.3 ms +16.88%
❌ test_north_star_validate_python 169.1 ms 206.6 ms -18.13%
❌ test_north_star_validate_python_strict 111.6 ms 135.6 ms -17.69%

@priya-gitTest
Copy link
Contributor Author

please review" to assign reviewers

yezz123
yezz123 reviewed Mar 23, 2024
View reviewed changes
Viicos
Viicos reviewed Mar 23, 2024
View reviewed changes
@sydney-runkle sydney-runkle added the relnotes-ignore Omit this PR from the release notes. label Mar 25, 2024
sydney-runkle
sydney-runkle suggested changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall, requested a few changes, thanks!!

@pydantic-hooky pydantic-hooky bot added awaiting author revision awaiting changes from the PR author and removed ready for review labels Mar 25, 2024
@pydantic-hooky pydantic-hooky bot assigned priya-gitTest and unassigned hramezani Mar 25, 2024
priya-gitTest
priya-gitTest commented Mar 25, 2024
View reviewed changes
Copy link
Contributor Author

@priya-gitTest priya-gitTest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly check. Missing authors also added now.

sydney-runkle
sydney-runkle reviewed Mar 25, 2024
View reviewed changes
sydney-runkle
sydney-runkle approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@sydney-runkle sydney-runkle enabled auto-merge (squash) March 25, 2024 20:48
@sydney-runkle sydney-runkle merged commit df5be31 into pydantic:main Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Viicos Viicos Viicos left review comments

+2 more reviewers

@yezz123 yezz123 yezz123 left review comments

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@priya-gitTest priya-gitTest

Labels
awaiting author revision awaiting changes from the PR author relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to Cite pydantic
5 participants
@priya-gitTest @yezz123 @sydney-runkle @Viicos @hramezani