Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support contextually overriding agent instructions #2926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Oct 1, 2025
Merged

Support contextually overriding agent instructions #2926

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
66b5270
Support overriding agent instructions
mwildehahn Sep 15, 2025
e5c9c0f
Review feedback
mwildehahn Sep 18, 2025
4c5defd
Fix type error
mwildehahn Sep 18, 2025
57d1b75
Rename test file
mwildehahn Sep 18, 2025
faf126e
Fix lint errors
mwildehahn Sep 18, 2025
753ce5d
Formatting tweaks
mwildehahn Sep 18, 2025
6f54670
Add coverage
mwildehahn Sep 18, 2025
9a30a71
Fix lint errors
mwildehahn Sep 18, 2025
682d232
Fix lint error
mwildehahn Sep 18, 2025
d12245c
Add helper function
mwildehahn Sep 18, 2025
3fc144f
Change variable name
mwildehahn Sep 18, 2025
e42630e
Add more tests
mwildehahn Sep 18, 2025
57d1523
Address review comments
mwildehahn Sep 24, 2025
122c040
Lint
mwildehahn Sep 24, 2025
37a48d8
Fix instruction typing
mwildehahn Sep 24, 2025
2b7459f
Fix typing
mwildehahn Sep 24, 2025
7aef1ab
Ignore coverage
mwildehahn Sep 26, 2025
1fd3627
...cool cool
mwildehahn Sep 26, 2025
02add1c
Review feedback
mwildehahn Oct 1, 2025
cfd880a
Fix formatting
mwildehahn Oct 1, 2025
f54f0e2
Update comment
mwildehahn Oct 1, 2025
ce4205b
Update docstrings to be consistent
mwildehahn Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
...cool cool
  • Loading branch information
@mwildehahn
mwildehahn committed Oct 1, 2025
commit 1fd362764345eb2e60e5875668eb0e53c068c46c
4 changes: 2 additions & 2 deletions pydantic_ai_slim/pydantic_ai/agent/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,8 +398,8 @@ def _append_instruction(self, instruction: _system_prompt.SystemPromptFunc[Agent
instructions_list = [self._instructions, instruction]
elif callable(self._instructions):
instructions_list = [self._instructions, instruction]
else: # pragma: no cover
instructions_list = [*self._instructions, instruction]
else:
instructions_list = [*self._instructions, instruction] # pragma: no cover
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for continuing to come up with more ways to refactor this, but what do you think about making self._instructions and self._override_instructions always hold a list[str | _system_prompt.SystemPromptFunc[AgentDepsT]], and change __init__ and override to store list(instructions) so that any single items automatically get wrapped in a list, and this method and the one above can be much simpler?


self._instructions = instructions_list

Expand Down