This repository was archived by the owner on Apr 11, 2026. It is now read-only.
Relax intensity of error for issubclass and isinstance schemas from json#1479
Merged
Conversation
CodSpeed Performance ReportMerging #1479 will not alter performanceComparing Summary
|
davidhewitt
reviewed
Oct 10, 2024
davidhewitt
left a comment
Collaborator
There was a problem hiding this comment.
The overall motivation of the change looks good, though I wonder about an alternative naming?
255cf2d to
68f000d
Compare
davidhewitt
pushed a commit
to pydantic/pydantic
that referenced
this pull request
Oct 20, 2025
…om json (pydantic/pydantic-core#1479) Original-commit-hash: b773c9d
davidhewitt
pushed a commit
to pydantic/pydantic
that referenced
this pull request
Oct 22, 2025
…om json (pydantic/pydantic-core#1479) Original-commit-link: pydantic/pydantic-core@b773c9d
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes pydantic/pydantic#8890
Makes these more compatible with validation in unions.