remove string ',' in quote price #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace(',','')
this will facilitate the conversion from string to float, and avoid exception
|
this string ',' removal is especially important for handling index price |
|
This PR should close #345 |
|
For PEP8 you should write instead of |
this string ',' removal is especially important for handling index price e.g. INDEXHANGSENG:HSI the original quote price is a string with ',' to show the thousand price point which will cause error when converting to float edited for PEP8 this is a re-summit as Im seeing some requests on this issue, wish could pass the test
Closed
|
thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace(',','')
this will facilitate the conversion from string to float, and avoid exception