Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix static typing with Matplotlib 3.8 #8030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Sep 17, 2023
Merged

Fix static typing with Matplotlib 3.8 #8030

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
fd2c467
fix several typing issues with mpl3.8
headtr1ck Jul 29, 2023
a97d634
Merge branch 'main' into pr/8030
Illviljan Aug 3, 2023
63409a5
Merge branch 'main' into mpltypes
headtr1ck Sep 5, 2023
3b62890
fix scatter plot typing and remove funky pyplot import
headtr1ck Sep 5, 2023
7b44b1b
fix some more typing errors
headtr1ck Sep 5, 2023
9051f30
fix some import errors
headtr1ck Sep 7, 2023
55a63b6
undo some typing errors
headtr1ck Sep 7, 2023
9e2c352
fix xylim typing
headtr1ck Sep 7, 2023
42d3356
add forgotten import
headtr1ck Sep 11, 2023
b5d2249
ignore plotting overloads because None is Hashable
headtr1ck Sep 11, 2023
d1cc216
add whats-new entry
headtr1ck Sep 11, 2023
428a1ed
fix return type of hist
headtr1ck Sep 11, 2023
2ab1402
fix another xylim type
headtr1ck Sep 11, 2023
db0db64
fix some more xylim types
headtr1ck Sep 11, 2023
3809152
Merge branch 'main' into mpltypes
headtr1ck Sep 11, 2023
8897ba1
change to T_DataArray
headtr1ck Sep 12, 2023
c318096
Merge branch 'main' into mpltypes
headtr1ck Sep 12, 2023
64c2401
change accessor xylim to tuple
headtr1ck Sep 12, 2023
79a92f5
add missing return types
headtr1ck Sep 12, 2023
b9dcc6a
fix a typing error only on new mpl
headtr1ck Sep 12, 2023
1eef361
add unused-ignore to error codes for old mpl
headtr1ck Sep 12, 2023
f7246fe
add more unused-ignore to error codes for old mpl
headtr1ck Sep 12, 2023
33c6f20
replace type: ignore[attr-defined] with assert hasattr
headtr1ck Sep 12, 2023
06e4337
Merge branch 'main' into mpltypes
headtr1ck Sep 16, 2023
b1d721c
apply code review suggestions
headtr1ck Sep 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix some more xylim types
  • Loading branch information
@headtr1ck
headtr1ck committed Sep 11, 2023
commit db0db6408c30c2e62868265c28135848cc35a4b1
16 changes: 8 additions & 8 deletions xarray/plot/dataarray_plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,8 +325,8 @@ def line( # type: ignore[misc] # None is hashable :(
yscale: ScaleOptions = None,
xticks: ArrayLike | None = None,
yticks: ArrayLike | None = None,
xlim: ArrayLike | None = None,
ylim: ArrayLike | None = None,
xlim: tuple[float, float] | None = None,
ylim: tuple[float, float] | None = None,
add_legend: bool = True,
_labels: bool = True,
**kwargs: Any,
Expand All @@ -336,7 +336,7 @@ def line( # type: ignore[misc] # None is hashable :(

@overload
def line(
darray,
darray: DataArray,
*args: Any,
row: Hashable, # wrap -> FacetGrid
col: Hashable | None = None,
Expand All @@ -353,8 +353,8 @@ def line(
yscale: ScaleOptions = None,
xticks: ArrayLike | None = None,
yticks: ArrayLike | None = None,
xlim: ArrayLike | None = None,
ylim: ArrayLike | None = None,
xlim: tuple[float, float] | None = None,
ylim: tuple[float, float] | None = None,
add_legend: bool = True,
_labels: bool = True,
**kwargs: Any,
Expand All @@ -364,7 +364,7 @@ def line(

@overload
def line(
darray,
darray: DataArray,
*args: Any,
row: Hashable | None = None,
col: Hashable, # wrap -> FacetGrid
Expand All @@ -381,8 +381,8 @@ def line(
yscale: ScaleOptions = None,
xticks: ArrayLike | None = None,
yticks: ArrayLike | None = None,
xlim: ArrayLike | None = None,
ylim: ArrayLike | None = None,
xlim: tuple[float, float] | None = None,
ylim: tuple[float, float] | None = None,
add_legend: bool = True,
_labels: bool = True,
**kwargs: Any,
Expand Down