(Fish) Fix fish single quote backslash escape#3138
Open
987cj wants to merge 6 commits into
Open
Conversation
…ix/fish-squote-escape
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2821
Implements a fix for backslash quote escapes, and a small snippet test for them.
In regards to the ending backslashes, I’ve made the following changes:
'abc\\'works (backslash escape)'abc\'doesn’t work (registers as a quote escape, string not properly closed'abc\''works (properly escaped quote, string closed)This is tested within the code snippet : )
This works by recognising whether a quote is escaped, rather than recognising all escape characters (
'abc\\\'registers as a full string, despite the escapes not actually closing the string properly). As fish has some settings for handling escape characters, I felt it best to do it this way so it doesn't accidentally break some functionality I'm not aware of.