Lexer cleanup: naming, metadata, correctness, and Python/CSS/Lua updates#3151
Open
Berat121 wants to merge 45 commits into
Open
Lexer cleanup: naming, metadata, correctness, and Python/CSS/Lua updates#3151Berat121 wants to merge 45 commits into
Berat121 wants to merge 45 commits into
Conversation
…zy keyword, remove duplicate pycon alias
Member
|
Hi and thanks for your contribution. This is a large PR that's getting harder to review especially since you're adding more commits. Please split it into separate PRs for the different concerns - e.g. one for the all changes, one for the CSS updates etc. As for the file renames, I'm not too keen on them since they just cause churn (and the original module needs to be kept for compatibility anyway). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses naming inconsistencies, metadata errors, and correctness issues across the lexer codebase. Each change is a separate commit for easy review.
File Renaming
Correctness Fixes
Language Updates
Testing
Notes
aliasesintact for backwards compatibility.lazykeyword added for Python 3.15 (PEP 690).StarlarkLexerextracted fromPythonLexeraliases into its own class.LuaLexer/LuauLexermoved to dedicatedlua.pyfollowing the pattern ofpython.py,go.py,ruby.py, etc.