Markdown: highlight bold-italics#3152
Open
code-with-rashid wants to merge 1 commit into
Open
Conversation
The MarkdownLexer handled **bold** and *italic* spans but not the combined ***bold italics*** (and ___bold italics___) form, which fell through to plain text. Emit the existing Generic.EmphStrong token for these spans, matching them before the bold rules so the triple markers are not partially consumed. Closes pygments#3067
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MarkdownLexerhighlights**bold**and*italic*spans, but the combined bold-italics form***bold italics***(and___bold italics___) was not recognized and fell through to plainText:Pygments already has a dedicated
Generic.EmphStrongtoken for exactly this case, so this adds two inline rules that emit it. They are placed before the existing**/__bold rules so the triple markers aren't partially consumed.After:
Existing
**bold**,__bold__,*italic*,_italic_and thesnake***case***wordnon-emphasis behavior are unchanged.Tests
Extended
tests/examplefiles/md/example.mdwith bold-italics lines (both the emphasized form and thesnake***case***wordnon-match) and regenerated the golden output.pytest tests/examplefiles/md/ tests/test_basic_api.pypasses (2446 passed, 8 skipped).Closes #3067