Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jan-janssen
Copy link
Member

Use if statements rather than dataclasses or abstract classes

Use if statements rather than dataclasses or abstract classes
@jan-janssen jan-janssen added the format_black Launch the pyiron/actions black formatting routine label Jan 9, 2024
@jan-janssen jan-janssen marked this pull request as draft January 9, 2024 19:49
@jan-janssen jan-janssen marked this pull request as ready for review January 9, 2024 20:45
@jan-janssen jan-janssen requested a review from liamhuber January 9, 2024 20:48
# Conflicts:
#	atomistics/calculators/ase.py
#	atomistics/calculators/lammps/calculator.py
#	atomistics/calculators/lammps/helpers.py
#	atomistics/calculators/qe.py
#	atomistics/shared/thermal_expansion.py
#	atomistics/workflows/elastic/workflow.py
#	atomistics/workflows/evcurve/workflow.py
#	atomistics/workflows/phonons/workflow.py
Copy link
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes back to having strings all over the place, to which I am ideologically opposed.

@samwaseda and I often go back and forth a bunch reviewing PRs trying to convince each other, which is fun and results in some great code improvements. Honestly, here I don't think it's worth your time -- you're unlikely to get me to approve any change introducing this many string checks. If you want to ping others for review I won't be offended, and if there is consensus that this represents an improvement I'll "disagree and commit", but IMO this PR moves backwards.

@jan-janssen jan-janssen marked this pull request as draft January 10, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

format_black Launch the pyiron/actions black formatting routine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants