Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump pylint to 3.3.2, update changelog#10088

Merged
Pierre-Sassoulas merged 1 commit into
maintenance/3.3.xfrom
release-branch-3.3.2
Dec 1, 2024
Merged

Bump pylint to 3.3.2, update changelog#10088
Pierre-Sassoulas merged 1 commit into
maintenance/3.3.xfrom
release-branch-3.3.2

Conversation

@Pierre-Sassoulas
Copy link
Copy Markdown
Member

@Pierre-Sassoulas Pierre-Sassoulas commented Nov 20, 2024

False Positives Fixed

Other Bug Fixes

  • Fixes the issue with --source-root option not working when the source files are in a subdirectory of the source root (e.g. when using a /src layout).

    Closes Source root not correctly used #10026

@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Nov 20, 2024
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.3.2 milestone Nov 20, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (621ecf6) to head (cc3cf8c).
Report is 19 commits behind head on maintenance/3.3.x.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           maintenance/3.3.x   #10088   +/-   ##
==================================================
  Coverage              95.81%   95.81%           
==================================================
  Files                    174      174           
  Lines                  18951    18951           
==================================================
  Hits                   18157    18157           
  Misses                   794      794           
Files with missing lines Coverage Δ
pylint/__pkginfo__.py 100.00% <100.00%> (ø)

Comment thread examples/pylintrc Outdated
Comment on lines +459 to +461
# Whether or not to search for fixme's in docstrings.
check-fixme-in-docstring=no

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very suspicious : #10009

Copy link
Copy Markdown
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, then let's pump the brakes until we get fixme-in-docstring extracted. (Sorry if that was me!)

@Pierre-Sassoulas
Copy link
Copy Markdown
Member Author

I don't understand what's happening, but I start to be suspicious of the tbump script, as the code added to the misc checker clearly isn't present in the maintenance branch.

@Pierre-Sassoulas Pierre-Sassoulas merged commit a5a1bc3 into maintenance/3.3.x Dec 1, 2024
@Pierre-Sassoulas Pierre-Sassoulas deleted the release-branch-3.3.2 branch December 1, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants