Fix progressbar with nested compound step samplers #7776
+56
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issues with the progress bar when using nested compound step samplers. Key changes include:
- Renaming update stats function(s) across several step method modules.
- Revising the logic for accumulating and mapping progress stats.
- Adjustments to support multiple update functions in the progress bar update routines.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pymc/util.py | Updates progress stats accumulation; renames update function |
| pymc/step_methods/slicer.py | Replaces singular update function with a tuple of functions |
| pymc/step_methods/metropolis.py | Updates update stats function to rename "accept" key appropriately |
| pymc/step_methods/hmc/nuts.py | Uses new update functions pattern |
| pymc/step_methods/compound.py | Refactors compound step update functions accordingly |
| for step_stats in chain_progress_stats: | ||
| for key, val in step_stats.items(): | ||
| if key in all_step_stats: | ||
| continue |
There was a problem hiding this comment.
The 'continue' statement immediately after checking if the key exists prevents the subsequent duplicate-key handling code (which calculates a new suffix) from ever executing. Consider removing 'continue' so that duplicate keys are properly renamed.
Suggested change
| continue |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #7730 that fixes #7721 and fixes #7724