Don't try to infer support shape of multivariate RVs by default #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The errors raised by the default when it fails are rather cryptic Also fix bug in helper function
The RV always expects a vector input and `ndims_paramas` is always `[1]`. Size is no longer ignored
cc96a16 to
d0b19e2
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
==========================================
- Coverage 80.46% 80.46% -0.01%
==========================================
Files 156 156
Lines 45514 45517 +3
Branches 11148 11148
==========================================
+ Hits 36624 36626 +2
- Misses 6688 6689 +1
Partials 2202 2202
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default method is not robust and can lead to cryptic error messages.
In a discussion with a user https://discourse.pymc.io/t/pm-sample-prior-predictive-fails-with-incorrect-size-info-passed-to-the-rng-fn-function-of-the-randomvariable/12513 , they were trying to fake a multivariate distribution as a univariate because of the cryptic error induced by the default method.
We now raise
NotImplementedErrorby default, and include illustrative examples in the docstrings that should help users implementing this method.Also fixed a couple of minor bugs.
The changes will break RVs that relied on the default implementation. This should be easy to fix and won't go unnoticed.