Make reify check for existing names in the current TensorFlow graph #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, when we reify TensorFlow meta objects, we check the current graph for any
Operations with the same name as the metaOperationbeing reified. If there is such anOperationin the graph, we make sure it's equivalent to the metaOperationand return it if it is; otherwise, we throw a newMetaReificationError.Also, this PR introduces a work-around for direct construction of constant tensors (e.g.
mt.const(1, 'int32', 'Const')). Previously, this was causing errors because the first argument (i.e. thevalueparameter) wasn't aTensorPrototype. We could simply carry aroundTensorPrototyped values in the metaNodeDef, but that would cause other problems, so—instead—a wrapped version of thetf.raw_ops.Constfunction was added; it takes care of the conversion toTensorProto.