Use select to check if there is data available in the socket#310
Merged
dhoomakethu merged 1 commit intopymodbus-dev:devfrom Jun 23, 2018
Merged
Use select to check if there is data available in the socket#310dhoomakethu merged 1 commit intopymodbus-dev:devfrom
dhoomakethu merged 1 commit intopymodbus-dev:devfrom
Conversation
Skipping socket.error each time that there is no data to read in the socket make the CPU usage raise up, to fix the issue use select in order to know if there is data available.
daca01a to
f391262
Compare
dhoomakethu
approved these changes
Jun 23, 2018
Contributor
Author
|
@MarekLew Yep, sorry for the issue and thank u for your fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipping socket.error each time that there is no data to read
in the socket make the CPU usage raise up, to fix the issue use
select in order to know if there is data available.