Dev3.7 async keyword changes#346
Merged
dhoomakethu merged 9 commits intopymodbus-dev:dev3.7from Oct 23, 2018
Merged
Conversation
…names Updated requirements-docs.txt to include missing modules
Py37 changes merge
Commenting out python3.7 from Travis while waiting for support. You can run teh 3.7 tests with tox without issues
Contributor
Author
|
Just removed the python3.7 configuration from Travis while the 3.7 support is added to it |
|
I would love it if this could get merged into 3.7 branch That way I could easily test this in my project. |
Contributor
|
@NovapaX I can merge this in to 3.7 branch in some time, once I sync up the latest on master to dev3.7 branch. |
…ev3.7 # Conflicts: # CHANGELOG.rst # doc/conf.py # pymodbus/framer/ascii_framer.py # pymodbus/framer/binary_framer.py # pymodbus/framer/rtu_framer.py # pymodbus/framer/socket_framer.py # pymodbus/repl/client.py # pymodbus/repl/completer.py # pymodbus/server/asynchronous.py
Contributor
|
@dices Thanks for fixing the merge conflicts. I will take some time over the weekend to review and merge this in to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed pymodbus.server.async to pymodbus.server.asynchronous
Modified asyncio.async to use asyncio.ensure_future
Added missing prompt_toolkit dependency to requirements-docs.txt
Updated references in documentation
Updated examples