Limit content width - Take 2 #13
Conversation
pypa_theme/static/sidebar.js
Outdated
| @@ -71,7 +72,7 @@ $(function() { | |||
| bodywrapper.css('margin-left', bw_margin_collapsed); | |||
| sidebarbutton.css({ | |||
| 'margin-left': '0', | |||
| 'height': bodywrapper.height(), | |||
| 'height': documentwrapper.height(), | |||
There was a problem hiding this comment.
The reason for making this change is: If there's an element with margin at an extreme, the sidebar didn't take 100% height of the white portions on load.
This fixes that issue.
pypa_theme/static/sidebar.js
Outdated
| @@ -0,0 +1,194 @@ | |||
| /* | |||
There was a problem hiding this comment.
Why did we end up with a totally new file here for this? Seems unrelated to the body size change?
|
@jonparrot there's an inline comment and also 2 commits with summaries describing it.
I'm gonna assume it just slipped under the radar here. |
|
Gotcha, so you're essentially overriding the sidebar.js from the upstream theme? |
|
Yep.
…On Thu, 4 Jan 2018, 22:42 Jon Wayne Parrott, ***@***.***> wrote:
Gotcha, so you're essentially overriding the sidebar.js from the upstream
theme?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADH7SSO6SWr_RyS0qXpmdBboJ2Svh_gCks5tHQaTgaJpZM4RKRWT>
.
|
|
Sorry that it wasn't clear initially. Something had come up when I made the
PR so I made it in a hurry.
…On Thu, 4 Jan 2018, 22:46 Pradyun Gedam, ***@***.***> wrote:
Yep.
On Thu, 4 Jan 2018, 22:42 Jon Wayne Parrott, ***@***.***>
wrote:
> Gotcha, so you're essentially overriding the sidebar.js from the upstream
> theme?
>
> —
> You are receiving this because you were assigned.
>
>
> Reply to this email directly, view it on GitHub
> <#13 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ADH7SSO6SWr_RyS0qXpmdBboJ2Svh_gCks5tHQaTgaJpZM4RKRWT>
> .
>
|
|
No worries - just a question: is it possible for us to make the change to that script upstream and have it work for both variants? |
|
I didn't wanna fiddle with upstream. A quick look suggests this exact change will add 1em of height to the lower portion of the sidebar, for example when there's a list involved. It'll sort of be more consistent across various pages -- currently an element at an extreme that has a margin can cause |
|
In a word: Yes. |
|
Let's do it then. Python proper still isn't using the upstream theme (I need to pick that thread back up) |
|
Cool. I'll drop the change here and put it in there. |
|
@jonparrott I've removed sidebar.js and made python/python-docs-theme#9. |
|
@pradyunsg great, we can merge this. :) |
|
Now to trigger a doc rebuild of pip, PyPUG and the rest. :P |
|
@jonparrott sphinx 1.7 has an upstream fix for this. I'm tempted to revert the changes here now and just move to the newer version of sphinx. |
|
Your thoughts? |
|
@pradyunsg I'm totally cool with that. |
From #11.
Some extra styling to make things look nicer.
Before:
After: