Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Modernize package_index VCS handling #4332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 30, 2024
Merged

Modernize package_index VCS handling #4332

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fe8980b
Remove pop_prefix parameter, unused.
jaraco Apr 29, 2024
35ee2b4
Add a test capturing the basic expectation.
jaraco Apr 29, 2024
eb42e5c
Update _vcs_split_rev_from_url to use modern constructs.
jaraco Apr 29, 2024
7c1c29b
package-index: Extract fall-through methods _download_vcs and _downlo…
jaraco Apr 29, 2024
4d54fa7
Extract _resolve_vcs for resolving a VCS from a URL.
jaraco Apr 29, 2024
cf18f71
Consolidated all _download_vcs methods into one.
jaraco Apr 29, 2024
f0cda0b
Replace os.system calls with subprocess calls.
jaraco Apr 29, 2024
a36b112
Prefer tmp_path fixture.
jaraco Apr 29, 2024
1a0cbf5
Add news fragment.
jaraco Apr 29, 2024
9bc2e87
Ignore coverage for file urls.
jaraco Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Ignore coverage for file urls.
  • Loading branch information
@jaraco
jaraco committed Apr 29, 2024
commit 9bc2e87fc74e726927d208438385956591c96aa5
2 changes: 1 addition & 1 deletion setuptools/package_index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,7 +880,7 @@ def _download_vcs(self, url, spec_filename):

def _download_other(self, url, filename):
scheme = urllib.parse.urlsplit(url).scheme
if scheme == 'file':
if scheme == 'file': # pragma: no cover
return urllib.request.url2pathname(urllib.parse.urlparse(url).path)
# raise error if not allowed
self.url_ok(url, True)
Expand Down