Conversation
Contributor
|
Hi @adang1345 thank you very much for working on this. The problem is likely related to a change in Python 3.13: https://docs.python.org/3.13/whatsnew/3.13.html#os-path. Could you please contribute the change directly to https://github.com/pypa/distutils? Everything under the |
Contributor
Author
|
I opened a pull request at pypa/distutils#302. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4669
Summary of changes
Fix an issue with Python 3.13 on Windows where specifying the absolute path to an extension module source file would cause the build files to be written to the directory containing the source file.
Closes #4669
Pull Request Checklist
newsfragments/.(See documentation for details)
I tested this change manually by using the
setup.pyandsimpleext.cfiles in the bug report and executingpy -3.13 setup.py build_ext. Before this change, the build files were written to the directory containing these files. After this change, the build files were instead written tobuild/temp.win-amd64-cpython-313. I am not sure whether there is an easy way to add an automated test for this.