🔧 fix(ci): restore git credentials for release and upgrade jobs#3102
Merged
Conversation
rahuldevikar
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zizmor security tool added
persist-credentials: falseto all checkout steps, which broke the rollback and upgrade workflows. These jobs push commits, tags, and force-push reverts to the repository, but stripping credentials after checkout caused authentication failures.Removing
persist-credentials: falsefrom the rollback job (usingGH_RELEASE_TOKEN) and upgrade job (usingDEPLOY_KEY) restores push capabilities. 🔐 Theartipackedwarnings are suppressed with inline ignores because they're false positives—neither job uploads artifacts that could leak credentials. The build job (which does upload artifacts) correctly keepspersist-credentials: false.This change only affects release/maintenance workflows. Regular CI checks remain protected with credential stripping intact.