fix: add missing properties to AlignedSegment type stubs #1273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These were added while the type hints PR #1008 was still in flight. So it is more that the latter was (understandably) not updated with additions on master before it was itself merged. In any case, thanks for the useful contribution. I've checked for other additions while the type hints were gestating — there were two, and I've added type stubs for them to your branch. |
jmarshall
approved these changes
Apr 19, 2024
|
Thanks @jmarshall ! |
jmarshall
added a commit
that referenced
this pull request
Oct 22, 2024
As each test is executed (thus verifying the actual code too), it invokes typecheck(). This runs mypy on the function that invoked it, parses the reveal_locals() output, and optionally checks that each local's hinted type is the same as its actual runtime time. This is optional because some tests require more nuanced checks; cf test_pileup_iterator_column() in which pileup()'s runtime type is a subclass of the hinted type. Add test cases for previously merged PRs #1273, #1296, and #1313. Also fix some pysam/libcbcf.pyi type hints that caused these tests to fail for unrelated reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1088 added
is_mappedandis_forward(and their mate equivalents) to theAlignedSegmentAPI, but didn't declare these properties in the corresponding type stubs. Their absence here causes downstream woes with mypy's type checking