-
Notifications
You must be signed in to change notification settings - Fork 15
Vector image support for imagetoVTK #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@renefritze what do you think? |
end = data.shape | ||
if hasattr(data,'shape'): | ||
end = data.shape | ||
elif(data[0].ndim==3 and data[1].ndim==3 and data[2].ndim==3): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
been forever since I've looked at this code but doesn't this assume 3D vector arrays?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it does - I only thought about using it for 3D vector fields like velocity etc.
Would it be worth generalising it to higher dimensional vectors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should support whatever the format supports but I've long passed the reigns to @renefritze so I'll let him decide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me. I think a generalization to N-d can still happen when someone needs it.
So the question is, @JonTong would you want to add the general case? |
I'm happy to look at adding the general case in the near future. |
Great!
TBH, I can't really say, since I don't have a use case. Just do what's useful for you first I'd say. |
I reckon @renefritze is right, lets merge this in and should people want the generalised version we can revisit. |
No description provided.