Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix #2056 - Provide a default empty config per editor env #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2024

Conversation

WebReflection
Copy link
Contributor

@WebReflection WebReflection commented May 13, 2024

Description

This MR fixes #2056 by providing a default config when no explicit config is used. The reason is that we now expect a default config to attach properties on PyScript side that can be read out of the box but because the editor is a bootstrap a part that config needed to be normalized and that's what happens in here.

Changes

  • if no config is explicitly provided, attach an empty literal as env config to the editor
  • test that both Pyodide and MicroPython actually do work as expected

Checklist

  • All tests pass locally
  • I have updated CHANGELOG.md
  • I have created documentation for this(if applicable)

@WebReflection WebReflection merged commit d1a0d8e into pyscript:main May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

py-editor shows error in 2024.5.1
2 participants