Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix #2360 - Better shared env/setup handling #2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025

Conversation

WebReflection
Copy link
Contributor

Description

This MR fixes #2360 by handling properly all x-editors that are sharing the same env or depends on the same setup node.

Changes

  • improve handling of setup and shared envs to bootstrap from scratch all related editors
  • manually test that everything works as expected (as it's hard to do an integration test here)

Checklist

  • I have checked make build works locally.
  • I have created / updated documentation for this change (if applicable).

@WebReflection WebReflection requested a review from ntoll July 10, 2025 10:57
Copy link
Member

@ntoll ntoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@WebReflection WebReflection force-pushed the stack branch 2 times, most recently from 9cfe01b to dd369d4 Compare July 10, 2025 13:26
@WebReflection WebReflection merged commit eaa6711 into pyscript:main Jul 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyEditor stop is actually not stopping when setup and shared env are used
2 participants